Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons on Files field #384

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Fix icons on Files field #384

merged 2 commits into from
Mar 16, 2023

Conversation

potsky
Copy link
Contributor

@potsky potsky commented Mar 14, 2023

Hi !

The delete button has disappeared on the Files class.

Here is the code with the Images class where the delete button is shown:
Images

Here is the code with the Files class where the delete button is not shown:
Files

@OwlHowl3
Copy link

@bkintanar Any chance you can merge this in, please?

@bkintanar
Copy link
Collaborator

@potsky can you do a build and include the dist files in your PR please?

@potsky
Copy link
Contributor Author

potsky commented Mar 16, 2023

@potsky can you do a build and include the dist files in your PR please?

Hi @bkintanar, it seems the project does not compile anymore. There is no lock file for package.json :-( BTW the current dependencies are incorrect. "vue-loader": "^16.2.0" is incompatible with "vue": "^2.5.17", we need to keep "vue-loader": "^15.0.0"... I'll try to fix the packages and ship a working lock file.

commit eb5b411
Author: Potsky <[email protected]>
Date:   Thu Mar 16 14:09:34 2023 +0100

    Fix clearfix and publish assets
@potsky
Copy link
Contributor Author

potsky commented Mar 16, 2023

Done @bkintanar and fixes #383 #382

Files are still displayed inline but now the Add New file is on a new line. In fact there is no .clearfix class...

@bkintanar bkintanar merged commit f764813 into ebess:master Mar 16, 2023
@OwlHowl3
Copy link

@potsky @bkintanar Thanks!

YouneselBarnoussi pushed a commit to YouneselBarnoussi/advanced-nova-media-library that referenced this pull request Mar 21, 2023
* Fix icon on Files field

* Fix clearfix and publish assets

commit eb5b411
Author: Potsky <[email protected]>
Date:   Thu Mar 16 14:09:34 2023 +0100

    Fix clearfix and publish assets
YouneselBarnoussi pushed a commit to YouneselBarnoussi/advanced-nova-media-library that referenced this pull request Mar 21, 2023
* Fix icon on Files field

* Fix clearfix and publish assets

commit eb5b411
Author: Potsky <[email protected]>
Date:   Thu Mar 16 14:09:34 2023 +0100

    Fix clearfix and publish assets
YouneselBarnoussi pushed a commit to YouneselBarnoussi/advanced-nova-media-library that referenced this pull request Mar 21, 2023
* Fix icon on Files field

* Fix clearfix and publish assets

commit eb5b411
Author: Potsky <[email protected]>
Date:   Thu Mar 16 14:09:34 2023 +0100

    Fix clearfix and publish assets
@ziming
Copy link

ziming commented Mar 29, 2023

@bkintanar can tag a release?

@bkintanar
Copy link
Collaborator

@ziming sorry got busy and forgot. Done now.

Gompje pushed a commit to DaktaDeo/advanced-nova-media-library that referenced this pull request Mar 29, 2024
* Fix icon on Files field

* Fix clearfix and publish assets

commit eb5b411
Author: Potsky <[email protected]>
Date:   Thu Mar 16 14:09:34 2023 +0100

    Fix clearfix and publish assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants