Annotate and fix compare module #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimize imports
Codecov Report
@@ Coverage Diff @@
## development #313 +/- ##
===============================================
- Coverage 39.7% 39.65% -0.06%
===============================================
Files 35 35
Lines 6944 6953 +9
Branches 1661 1664 +3
===============================================
Hits 2757 2757
- Misses 3976 3985 +9
Partials 211 211
Continue to review full report at Codecov.
|
ebroecker
previously approved these changes
Mar 5, 2019
altendky
requested changes
Mar 6, 2019
ebroecker
dismissed
their stale review
@altenky requested changes, so my "aprove" was to early
|
@altendky thx for the valuable input. Please read my answers and check if the typevar and type alias are acceptable. |
…into annotate_fix_compare
…anmatrix into annotate_fix_compare
ebroecker
approved these changes
Mar 10, 2019
altendky
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate, refactor (snake_case) and fix (old function names from
canmatrixmodule)comparemodule.There is still minor issue with accessing "protected" members of CompareResult. I'll try to attr.ibify the Compareresult in follow-up PR.