Constness on getters and setters

ebu · Dec 14, 2023 · 7cad1a2 · 7cad1a2
1 parent b3ba4c8
commit 7cad1a2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/shared/update_check_settings_file.cpp b/shared/update_check_settings_file.cpp
@@ -16,23 +16,23 @@ UpdateCheckerSettingsFile::UpdateCheckerSettingsFile()
     loadSettings();
 }
 
-bool UpdateCheckerSettingsFile::getAutoCheckEnabled()
+const bool UpdateCheckerSettingsFile::getAutoCheckEnabled()
 {
     return settingAutoCheckEnabled;
 }
 
-bool UpdateCheckerSettingsFile::setAutoCheckEnabled(bool enabled)
+const bool UpdateCheckerSettingsFile::setAutoCheckEnabled(bool enabled)
 {
     settingAutoCheckEnabled = enabled;
     return saveSettings();
 }
 
-Version UpdateCheckerSettingsFile::getLastReportedVersion()
+const Version UpdateCheckerSettingsFile::getLastReportedVersion()
 {
     return settingLastReportedVersion;
 }
 
-bool UpdateCheckerSettingsFile::setLastReportedVersion(Version version)
+const bool UpdateCheckerSettingsFile::setLastReportedVersion(const Version& version)
 {
     settingLastReportedVersion = version;
     return saveSettings();

diff --git a/shared/update_check_settings_file.h b/shared/update_check_settings_file.h
@@ -7,11 +7,11 @@ class UpdateCheckerSettingsFile {
 public:
     UpdateCheckerSettingsFile();
 
-    bool getAutoCheckEnabled();
-    bool setAutoCheckEnabled(bool enabled);
+    const bool getAutoCheckEnabled();
+    const bool setAutoCheckEnabled(bool enabled);
 
-    Version getLastReportedVersion();
-    bool setLastReportedVersion(Version version);
+    const Version getLastReportedVersion();
+    const bool setLastReportedVersion(const Version& version);
 
     const bool canRead();
     const bool canWrite();