Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128 channel support with user feedback #254

Merged
merged 34 commits into from
Nov 3, 2023
Merged

128 channel support with user feedback #254

merged 34 commits into from
Nov 3, 2023

Conversation

firthm01
Copy link
Contributor

Supercedes #253 - same fixes + additional commits for user feedback when channel limits are exceeded on import

firthm01 added 25 commits April 3, 2023 14:09
@firthm01
Initial changes for 128 channels
40283ca 
totally untested
@firthm01
Remove unused 64-channel limited funcs
5df3fdd
@firthm01
Update test for channel out-of-bounds
8d34671
@firthm01
rn global_config.h daw_channel_count.h
bc48869
@firthm01
Funcs to get DAW channel count
a11a9b5
@firthm01
Full bus routing uses api.GetDawChannelCount()
9cfcce3 
tests updated too
@firthm01
EAR UniqueValueAssigner should only use currently available channels
aa10ba2
@firthm01
EarComboBoxEntry::setSelectable and make visible changes
546daa4
@firthm01
getEntryById to retrieve EarComboBoxEntry object
bd62ad9 
existing getEntryById  method renamed to getEntryIndexById since that's more accurate of what it did.
@firthm01
getPopup method so parent classes can access entries
0e38b33
@firthm01
Impl DAW channel count UI changes in Obj plugin
3fd8fb6
@firthm01
add*Entry methods return the constructed entry
cee7e33
@firthm01
Impl DAW channel count UI changes in HOA plugin
b43d110
@firthm01
Impl DAW channel count UI changes in DS plugin
f15d61d
@firthm01
Error message for missing AXML/CHNA chunk
2768bc0
@firthm01
Routing info tooltip on REAPER <v7 (Obj plugin)
4f2dd24
@firthm01
Routing info tooltip on REAPER <v7 (HOA plugin)
d031971
@firthm01
Routing info tooltip on REAPER <v7 (DS plugin)
4099b4e
@firthm01
Recentre the DS meters
935f83c
@firthm01
Import classes support receiving warning messages
ed555b8
@firthm01
Import dialog only closes automatically if no warnings occurred
1623858
@firthm01
Handle ImportStatus::COMPLETE state only once
6fd222d 
Move out of state-polling timer method and in to onStateChanged
@firthm01
PluginSuites can pass back error messages
8060c7d
@firthm01
Show warnings to user
8fd1516
@firthm01
Might as well implement warnings about unsupported PFs
c3d70d0
@firthm01 firthm01 mentioned this pull request Oct 12, 2023
Closed
@firthm01
Copy link
Contributor Author

Code review notes;

General approach was to make everything support 128 channels under the hood. Some areas needed to know the actual supported channels of the DAW (e.g, for routing during import and for UI), so there were some helper funcs for that.

Tasks

  • Add a global #define to set the channel count - change all hard-coded channel counts to use this. For routing, we need to know exactly how many channels the DAW supports so we don't use out-of-range values (e.g, REAPER older than v7). This is done with helper functions.
    main...aa10ba2

  • UI changes:

    • Decided to list channels up to the maximum, but to just disable unsupported ones in the dropdown - this required some changes to the EarComboBox* classes to support disabling entries
      aa10ba2...f15d61d
    • Show an icon and a tooltip if not all channels are available. For DS plugin, this required widening the left column and recentring the meters afterwards.
      2768bc0...935f83c

  • User feedback when problems occur during import;

    • ImportListener (and so ImportBroadcaster) supports warnings. A little crude using just a string, but didn't think it was worth over-engineering it at this stage. Keeps counts of warnings rather than storing dupes.
      935f83c...1623858
    • ImportStatus::COMPLETE state was handled in the import dialog timer method so was ran repeatedly. Moved it so it only runs once (onStateChanged)
      1623858...6fd222d
    • ImportBroadcaster ptr passed to the PluginSuite classes at the start of import so they can pass back warnings - warns about channels and also about unsupported PFs. Warnings displayed in import dialog.
      6fd222d...c3d70d0

  • (slightly unrelated) Show a more helpful error message when you try to import non-ADM - came across this during testing
    f15d61d...2768bc0

@firthm01 firthm01 requested a review from rsjbailey October 18, 2023 13:28
@firthm01 firthm01 self-assigned this Oct 18, 2023
@firthm01 firthm01 force-pushed the 128ch-limit-warning branch from 1e16251 to a7d37bc Compare November 3, 2023 10:52
@firthm01
Copy link
Contributor Author

firthm01 commented Nov 3, 2023

Suggestions implemented. Diff since last review; b2ec02f...a7d37bc

@firthm01 firthm01 merged commit e14ba77 into main Nov 3, 2023
6 checks passed
@firthm01 firthm01 deleted the 128ch-limit-warning branch November 3, 2023 12:24
@firthm01
Copy link
Contributor Author

Closes #244

@troullll
Copy link

ear object routing is limited by 64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsjbailey rsjbailey rsjbailey left review comments

Assignees

@firthm01 firthm01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firthm01 @troullll @rsjbailey