Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required version attribute to 2076-2 ADM #255

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

firthm01
Copy link
Contributor

@firthm01 firthm01 commented Oct 12, 2023

Closes #248

Fairly simple. Update libadm and set the version attribute in the two places we create an ADM Document. For EAR, this is done in the Scene plugin. For other plugin suites, this is done in the export code for the ADM Export Source plugin.

@firthm01 firthm01 requested a review from rsjbailey October 18, 2023 18:58
@firthm01 firthm01 self-assigned this Oct 18, 2023
@firthm01 firthm01 merged commit af9c14b into main Dec 4, 2023
6 checks passed
@firthm01 firthm01 deleted the fix-248-version-attr branch December 4, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version attribute is required when using BS.2076-2 structures
2 participants