-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom IR selection in Binaural Monitoring plugin #266
Conversation
eda941f
to
97e7d1d
Compare
e3c784f
to
e5fcbfe
Compare
(using juce::var)
saves parsing to a juce::File each time we need to use it
better description of what it actually does. for error status and retrieval, we'll use BearStatus
Feedback is now sent to UI
Caused by trying to use wrong ID after full path change
No need to store BearStatus. FEC is only interested in what colour and text it should use.
Multiline support and proper height deduction needed
dummy data
d127c20
to
ece9fe4
Compare
Force push was reordering of commits to organise in to ranges of consecutive commits by the task they satisfied (was a bit back-and-forth originally) |
Code review notes;General minor issues found during work: 66f273c8c46cd4544972eb05e9c2591deba03912^...11488c3
|
TODO: Update BEAR once default file updated with metadata and changes merge to main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed via #270
Cleaner code + additional fixes on #270 - merge that one instead |
As discussed with team, feature will be somewhat covert as intended for advanced users.
The solution will check for expected, pre-installed TF files, such as default_small.tf - this location will be alongside the VST on Windows, or within the Resources folder of the VST bundle on MacOS.
We also search for additional TF files in the same directory as the VST on both MacOS and Windows (we do not search for additional files within the VST bundle on MacOS because this encourages people to place their TFs within the bundle which could then get deleted if the user uninstalls/upgrades the EPS.
If more than one TF file is available, the Binaural Monitoring UI will display a drop-down menu to select the TF file to use. This drop-down will NOT be visible if only one TF file is found and if it is one of the pre-installed BEAR-released TFs. Since the UI default size is already oversized to accommodate the welcome screen, there is plenty of space to place additional controls. For the average user (those who have not generated additional TF files), the behaviour and appearance of the Binaural Monitoring plugin is unchanged.
The drop-down (if present) will present a list of TF files found. There will be a text label which can be used to display the status and/or success state of the loading of the TF file. Each TF file will be detailed in the drop-down entry. BEAR-released TF's should be emphasised and prioritised, and non-BEAR-released TF's should be clearly marked as such.
The user can use the drop-down to select the data file to use. In this case, BEAR is reinitialised with the new data file. If loading of the data file fails, an error is shown in the status text label. If the load success, the label states that the renderer is running.