This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Fix endless loop when updating URL aliases pointing to orphaned entities #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My last commit was agreed upon, with @pfrenssen, after a discussion we had in the chat. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are URL aliases present in the database that reference orphaned RDF entities then the batch process gets stuck in an endless loop. This is caused by the counter being incremented with the number of entities returned from the database, rather than with the number of aliases that are attempted to be generated. If there is an orphaned alias present then the count will never reach the total and the batch process will loop endlessly.
This also fixes incomplete messages being shown when trying to display the entity IDs of orphaned entities.