Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a wallet provider for wallet connect 2 #2145

Closed
12 of 14 tasks
roxaneletourneau opened this issue Nov 23, 2022 · 0 comments · Fixed by #3045 · May be fixed by #2059
Closed
12 of 14 tasks

Implement a wallet provider for wallet connect 2 #2145

roxaneletourneau opened this issue Nov 23, 2022 · 0 comments · Fixed by #3045 · May be fixed by #2059
Assignees
Labels
Milestone

Comments

@roxaneletourneau
Copy link
Collaborator

roxaneletourneau commented Nov 23, 2022

Is your feature request related to a problem and use case? Please describe.

Allow dapps to connect to wallets through wallet connect 2. Allow to send operations and sign payload.

Describe the solution you'd like

  • Create a new package for wallet connect 2. The WalletConnect2 class implements the WalletProvider interface and acts as a wrapper around the wc sign client. WalletConnect2 is intended to be used in dapps in a very similar way to BeaconWallet.
  • Allow to configure WalletConnect2 with an existing pairing
  • Allow to configure WalletConnect2 with a new pairing/session using the QR code modal
  • Allow to configure WalletConnect2 with an existing session
  • wc2 allows to connect to multiple accounts; add a method setActiveAccount that the dapp needs to call to specify which account is used; the method needs to be called every time the active account is changed in the dapp
  • Namespace validate; reject the session if the namespace returned by the wallet is invalid
  • Permission handling; reject operation if the session doesn't have the correct permission
  • Add a listener for session_delete. It informs when a session is deleted on the wallet side. If the topic of the deleted session corresponds to the topic of the session member in the WalletConnect2 class, set session to undefined.
  • Add listeners for session_update, to update the session stored in the WalletConnect2 class accordingly.
  • What happens if the chain/network is changed in the wallet? Can we give permission for multiple networks at once? (Yes) How to know what is the active network?
  • What happens if the account is changed in the wallet? Which event listener needs to be used?
  • Add unit tests
  • Add a parameter named registryUrl to the requestPermissions method that allows specifying wallets displayed in the Modal.
  • Provide a default list of all Tezos wallets compatible with wc2 that can be passed as the registryUrl param.
@roxaneletourneau roxaneletourneau self-assigned this Nov 23, 2022
@Innkst Innkst added this to the v15 milestone Nov 25, 2022
@roxaneletourneau roxaneletourneau modified the milestones: v15, v15.1 Dec 7, 2022
@Innkst Innkst modified the milestones: v15.1, v16.1 Jan 11, 2023
@Innkst Innkst assigned ac10n and unassigned roxaneletourneau Apr 5, 2023
@Innkst Innkst modified the milestones: v16.1, v16.2 Apr 11, 2023
@Innkst Innkst modified the milestones: v16.2, v17.2 Jun 1, 2023
@Innkst Innkst modified the milestones: v17.2, v17.3 Jul 13, 2023
@Innkst Innkst modified the milestones: v17.2, v17.3, v18.1 Aug 15, 2023
@Innkst Innkst modified the milestones: v18.1, v17.4 Oct 2, 2023
@hui-an-yang hui-an-yang removed this from the v19.1 milestone Mar 7, 2024
@hui-an-yang hui-an-yang added this to the v20+ milestone Mar 7, 2024
@ac10n ac10n moved this to To do in Taquito Dev Jun 21, 2024
@hui-an-yang hui-an-yang assigned hui-an-yang and unassigned ac10n Oct 2, 2024
@hui-an-yang hui-an-yang moved this from To do to In progress in Taquito Dev Oct 2, 2024
@hui-an-yang hui-an-yang modified the milestones: v20+, 20.1 Oct 2, 2024
@hui-an-yang hui-an-yang linked a pull request Oct 2, 2024 that will close this issue
9 tasks
@hui-an-yang hui-an-yang modified the milestones: 20.1, 21, v21, v20.1 Oct 2, 2024
@hui-an-yang hui-an-yang modified the milestones: v20.1, NEXT Nov 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Taquito Dev Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
4 participants