Wc 2 #3045

hui-an-yang · 2024-09-12T00:46:10Z

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

Your code builds cleanly without any errors or warnings
You have run the linter against the changes
You have added unit tests (if relevant/appropriate)
You have added integration tests (if relevant/appropriate)
All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
You have added or updated corresponding documentation
If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

github-actions · 2024-09-12T00:48:23Z

A new deploy preview is available on Cloudflare Pages at https://e146b661.taquito-test-dapp.pages.dev

github-actions · 2024-09-12T00:49:20Z

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

cloudflare-workers-and-pages · 2024-09-12T00:51:07Z

Deploying taquito with Cloudflare Pages

Latest commit:	`3397c63`
Status:	✅ Deploy successful!
Preview URL:	https://ceef620a.taquito.pages.dev
Branch Preview URL:	https://wc-2.taquito.pages.dev

View logs

…yet)

roxaneletourneau · 2024-10-25T12:35:14Z

packages/taquito-wallet-connect-2/src/taquito-wallet-connect-2.ts

+      this.getSession();
+      throw new ActiveAccountUnspecified();
+    }
+    return this.getSession().self.publicKey;


@hui-an-yang
When looking at the session returned by Kukai session.self.publicKey is not the Tezos public key of the active account:

thank you will updated the logic

Added support to sign payload in the test-dapp using wallet connect, fix getPk and sign in the wallet connect package

feat(wallet connect): sign payload using wc in test-dapp

roxaneletourneau

Looks good to me !

roxaneletourneau · 2024-11-07T14:33:13Z

packages/taquito-wallet-connect/src/types.ts

+  fee?: string;
+}
+
+export interface TransferParams


Wondering if it would make sense to move those types so we can use them in beacon package too

@roxaneletourneau Thank you, that'll be a great idea but it seems @airgap/beacon-types has their own type PartialTezosOperation and our walletAPI has type WalletParamsWithKind.
This also made me realize that even in walletconnect package supports all contractAPI operations but walletAPI doesn't support them that their use will be limited.
I'll merge this PR for now and start a new pr to support all contractAPI ops in walletAPI and consolidate the types

hui-an-yang added 4 commits July 26, 2024 06:58

Merge branch 'master' of https://github.com/ecadlabs/taquito

42a5799

Merge branch 'master' of https://github.com/ecadlabs/taquito

e45286c

Merge branch 'master' of https://github.com/ecadlabs/taquito

903169d

feat: revived @taquiot/wallet-connect-2 package

e0cb854

hui-an-yang mentioned this pull request Sep 12, 2024

walletconnect #3032

Closed

9 tasks

github-actions bot deployed to taquito-test-dapp (Preview) September 12, 2024 00:48 View deployment

hui-an-yang added 5 commits September 19, 2024 12:48

docs: adding website doc with live code example (modal isn't working …

bc60f8b

…yet)

feat: has qrcode modal working with @walletconnect/legacy-modal

37dd379

feat: fill-in wc2 logic of sing and getPK

410c28c

test: added unit test ofr sign and getPK

25d970a

Merge branch 'master' of https://github.com/ecadlabs/taquito into HEAD

e35c000

github-actions bot deployed to taquito-test-dapp (Preview) September 26, 2024 19:29 View deployment

This was linked to issues Oct 2, 2024

Support wallet connect 2 in the Taquito test dapp #2146

Closed

Implement a wallet provider for wallet connect 2 #2145

Closed

hui-an-yang added 3 commits October 10, 2024 10:00

Merge branch 'wc-2' of https://github.com/ecadlabs/taquito into wc-2

4502753

chore: dependencies update to fix vulnerbilities

902b352

Merge branch 'master' of https://github.com/ecadlabs/taquito into wc-2

f5fdb00

github-actions bot deployed to taquito-test-dapp (Preview) October 18, 2024 21:37 View deployment

roxaneletourneau reviewed Oct 25, 2024

View reviewed changes

feat: testdapp with walletconnect option

303376c

github-actions bot deployed to taquito-test-dapp (Preview) October 25, 2024 21:44 View deployment

roxaneletourneau and others added 3 commits November 1, 2024 12:16

feat(wallet connect): sign payload using wc in test-dapp

c1580f5

Added support to sign payload in the test-dapp using wallet connect, fix getPk and sign in the wallet connect package

Updated docs

ced7349

Merge pull request #3074 from ecadlabs/wc-2-test-dapp

b3d7259

feat(wallet connect): sign payload using wc in test-dapp

github-actions bot deployed to taquito-test-dapp (Preview) November 5, 2024 19:50 View deployment

hui-an-yang added 2 commits November 5, 2024 13:52

Merge branch 'wc-2' of https://github.com/ecadlabs/taquito into wc-2

94e78d2

fix: make verifySignatureWithTaquito walletconnect compatiable

1b993e0

hui-an-yang added 3 commits November 6, 2024 11:05

fix: resolve not subscribeToEvent ACTIVE_ACCOUNT_SET error in console

82bcbd5

fix: added registryUrl to fix console 404 error

b207276

chore: update dependencies

e3230bf

github-actions bot deployed to taquito-test-dapp (Preview) November 6, 2024 21:56 View deployment

hui-an-yang requested a review from roxaneletourneau November 6, 2024 21:57

hui-an-yang marked this pull request as ready for review November 6, 2024 21:57

refactor: rename from walletconnect2 to walletconnect

b9c0f1e

github-actions bot deployed to taquito-test-dapp (Preview) November 6, 2024 23:32 View deployment

roxaneletourneau approved these changes Nov 7, 2024

View reviewed changes

chore: updated sass to 1.80.1

ed93be8

github-actions bot deployed to taquito-test-dapp (Preview) November 7, 2024 21:55 View deployment

docs: added (BETA) to walletconnect package

3397c63

github-actions bot deployed to taquito-test-dapp (Preview) November 7, 2024 23:20 View deployment

hui-an-yang merged commit 1188bbc into master Nov 8, 2024
9 checks passed

hui-an-yang deleted the wc-2 branch November 8, 2024 00:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wc 2 #3045

Wc 2 #3045

hui-an-yang commented Sep 12, 2024

github-actions bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 12, 2024 •

edited

Loading

roxaneletourneau Oct 25, 2024

hui-an-yang Oct 25, 2024

roxaneletourneau left a comment

roxaneletourneau Nov 7, 2024

hui-an-yang Nov 7, 2024

Wc 2 #3045

Wc 2 #3045

Conversation

hui-an-yang commented Sep 12, 2024

Release Note Draft Snippet

github-actions bot commented Sep 12, 2024 • edited Loading

github-actions bot commented Sep 12, 2024 • edited Loading

Published packages:

cloudflare-workers-and-pages bot commented Sep 12, 2024 • edited Loading

Deploying taquito with Cloudflare Pages

roxaneletourneau Oct 25, 2024

Choose a reason for hiding this comment

hui-an-yang Oct 25, 2024

Choose a reason for hiding this comment

roxaneletourneau left a comment

Choose a reason for hiding this comment

roxaneletourneau Nov 7, 2024

Choose a reason for hiding this comment

hui-an-yang Nov 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 12, 2024 •

edited

Loading