-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2776 smart rollup origination with whitelist #2781
Changes from 11 commits
ab211c0
2ebbb06
9132f7c
c511cba
65da505
fa171e1
d25afb8
9866c63
0766c54
d8c1942
da9b6eb
40b1ec7
fc646c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,7 @@ | |
"ProxfordY", | ||
"PtNairobi", | ||
"refetched", | ||
"riscv", | ||
"rollups", | ||
"Roxane", | ||
"SAPLINGCONTRACT", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ import { | |
paddedBytesDecoder, | ||
parametersDecoder, | ||
pkhDecoder, | ||
pkhsDecoder, | ||
smartRollupMessageDecoder, | ||
proposalDecoder, | ||
proposalsDecoder, | ||
|
@@ -63,6 +64,7 @@ export const decoders: { [key: string]: Decoder } = { | |
[CODEC.ZARITH]: zarithDecoder, | ||
[CODEC.PUBLIC_KEY]: publicKeyDecoder, | ||
[CODEC.PKH]: pkhDecoder, | ||
[CODEC.PKH_ARR]: pkhsDecoder, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would you consider updating this to PKH_ARRAY or PKH_LIST instead for clarity? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At the time, trying to be consistent with existing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if the decoder going with pkhArrayDecoder will update this as PKH_ARRAY. |
||
[CODEC.DELEGATE]: delegateDecoder, | ||
[CODEC.INT32]: int32Decoder, | ||
[CODEC.SCRIPT]: scriptDecoder, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would the
s
be in this case inpkhs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the other comment inherit the naming consistency from
proposalsDecoder
, I thinks
means pluralThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for proposals it's because the operation itself is called
Proposals
instead ofproposal
.I think we can remove the
S
in this case, but that's just personal preference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are
proposalDecoder
andproposalsDecoder
. There is alreadypkhDecoder
will we considerpkhArrayDecoder
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's do pkhArrayDecoder then, seems more informative than just using
s
.