Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to operation estimation errors in batches #2797

Conversation

sergey-kintsel
Copy link
Contributor

It allows to find the faulty operation
Otherwise, it's just random guessing why it failed

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit cdb1144
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65a506dc8e363400088af34c
😎 Deploy Preview https://deploy-preview-2797--taquito-test-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

It allows to find the faulty operation
Otherwise, it's just random guessing why it failed
@sergey-kintsel sergey-kintsel force-pushed the add-more-info-to-estimation-errors branch from 6e3c0a0 to cdb1144 Compare January 15, 2024 10:20
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dsawali dsawali changed the base branch from master to batch-estimation-info January 17, 2024 19:06
@dsawali
Copy link
Contributor

dsawali commented Jan 17, 2024

I've changed the destination branch to batch-estimation-info so that we're able to test the website deployment more effectively.

@hui-an-yang hui-an-yang merged commit b1e7e68 into ecadlabs:batch-estimation-info Jan 17, 2024
9 of 12 checks passed
hui-an-yang added a commit that referenced this pull request Jan 19, 2024
* Add more info to operation estimation errors in batches (#2797)

It allows to find the faulty operation
Otherwise, it's just random guessing why it failed

Co-authored-by: Sergey Kintsel <[email protected]>

* docs: to trigger netlify rerun

---------

Co-authored-by: Sergey Kintsel <[email protected]>
Co-authored-by: Sergey Kintsel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants