wallet-porfolio #1183
Open
wallet-porfolio #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkildar
reviewed
Jan 10, 2023
src/common/api/hive-engine.ts
Outdated
| export async function getOtherTransactions(account: string, limit: number, symbol: string, offset: number = 0) { | ||
| const url: any = engine.otherTransactionsUrl; | ||
| const response = await axios({ | ||
| url: url, |
There was a problem hiding this comment.
You may leave just url instead of url: url
There was a problem hiding this comment.
oh, that's true,
Thanks🙏
dkildar
reviewed
Jan 10, 2023
|
|
||
| const getMainTransactions = async () => { | ||
| const transactions = await getTransactions(params, account.name, 200); | ||
| console.log(transactions) |
dkildar
reviewed
Jan 10, 2023
| const otherTokenTransactions = async () => { | ||
| setLoading(true) | ||
| const otherTransactions = await getOtherTransactions(account.name, 200, params.toUpperCase()); | ||
| console.log(otherTransactions) |
dkildar
reviewed
Jan 10, 2023
| }; | ||
|
|
||
| const optionChanged = (e: React.ChangeEvent<typeof FormControl & HTMLInputElement>) => { | ||
| console.log(e.target) |
There was a problem hiding this comment.
Do you use this function?
There was a problem hiding this comment.
Yeah, I haven't used it yet, I'll use it, I'm not done with issue yet, I want to be sure all actions/logic works then I will refactor where necessary
dkildar
reviewed
Jan 10, 2023
| @@ -234,6 +235,7 @@ export const WalletEcency = (props: Props) => { | |||
| const initiateOnElectron = (username: string) => { | |||
| if (!isMounted && global.isElectron) { | |||
| let getPoints = new Promise((res) => fetchPoints(username)); | |||
| console.log(getPoints) | |||
dkildar
reviewed
Jan 10, 2023
| @@ -199,6 +199,7 @@ export const WalletEcency = (props: Props) => { | |||
| const [showPurchaseDialog, setShowPurchaseDialog] = useState(false); | |||
|
|
|||
| const { global, activeUser, account, points, history, fetchPoints, updateActiveUser } = props; | |||
| console.log(points) | |||
dkildar
reviewed
Jan 10, 2023
|
|
||
| const marketChartInfo = async () => { | ||
| const data: any = await marketChart("hive") | ||
| console.log(data) |
There was a problem hiding this comment.
Thanks @dkildar, all console.log( ) would be removed, I'm still working on this issue, would clean all and refactor once I'm done
…into feat/redesign-wallet-page
dkildar
reviewed
Mar 13, 2023
| const url = `https://api.coingecko.com/api/v3/coins/${token}/market_chart?vs_currency=usd&days=30`; | ||
| const data = await axios.get(url) | ||
| .then((r: any) => r.data) | ||
| return data; |
There was a problem hiding this comment.
Please, do not use async/await and then constructions together.
It should be:
const { data } = await axis.get(url);
return data;
…into feat/redesign-wallet-page
dkildar
reviewed
Mar 13, 2023
| @@ -4,6 +4,7 @@ import { getMetrics } from "../../api/hive-engine"; | |||
|
|
|||
| export const EngineTokensEstimated = (props: any) => { | |||
| const { tokens: userTokens, dynamicProps } = props; | |||
| // console.log(userTokens) | |||
dkildar
reviewed
Mar 15, 2023
| const [transactions, setTransactions] = useState([]) | ||
| const [otherTransactions, setOtherTransactions] = useState([]) | ||
| const [loading, setLoading] = useState(false); | ||
| const [loadLimit, setLoadLimit] = useState(10) |
dkildar
reviewed
Mar 15, 2023
| } from "../../api/hive-engine"; | ||
| import LinearProgress from '../linear-progress'; | ||
|
|
||
| export const EngineTransactionList = (props: any) => { |
There was a problem hiding this comment.
It's not an any. Please, specify types
dkildar
reviewed
Mar 15, 2023
| return ( | ||
| <div className="transaction-list"> | ||
| <div className="transaction-list-header"> | ||
| <h2>{_t("transactions.title")} </h2> |
There was a problem hiding this comment.
Extra space at the end of tag content
dkildar
reviewed
Mar 15, 2023
| </div> | ||
| {loading && <LinearProgress />} | ||
| {otherTransactions?.slice(0, loadLimit).map((t: any) => { | ||
| return ( |
There was a problem hiding this comment.
Tip: You can replace
foo() => {
return bar;
}
with
foo() => (bar)
No need to use extra return
dkildar
reviewed
Mar 15, 2023
| <div className="transaction-list-item" key={t?.id}> | ||
| <div className="transaction-icon"> | ||
| {t?.operation === "tokens_transfer" || t?.operation === "tokens_stake" || t?.operation === "tokens_delegate" ? | ||
| TwoUserAvatar({ global: global, from: t?.from, to: t?.to, size: "small" }) : |
There was a problem hiding this comment.
Its a component, use as element please
dkildar
reviewed
Mar 15, 2023
| <span> | ||
| <strong>{`Txn Id: ${t.transactionId}`}</strong> | ||
| <p className='mt-2'> | ||
| <strong>{`Block Id: ${t.blockNumber}`}</strong> |
There was a problem hiding this comment.
These texts should be translated
dkildar
reviewed
Mar 15, 2023
| import { marketChart } from '../../api/misc' | ||
| import moment from "moment"; | ||
|
|
||
| export const HiveWalletPortfolioChart = (props: any) => { |
dkildar
reviewed
Mar 15, 2023
| export const HiveWalletPortfolioChart = (props: any) => { | ||
| const { theme } = props; | ||
|
|
||
| const [prices, setPrices] = useState([]) |
dkildar
reviewed
Mar 15, 2023
|
|
||
| const { global, account, params } = props | ||
|
|
||
| const [transactions, setTransactions] = useState([]) |
dkildar
reviewed
Mar 15, 2023
| const { global, account, params } = props | ||
|
|
||
| const [transactions, setTransactions] = useState([]) | ||
| const [otherTransactions, setOtherTransactions] = useState([]) |
dkildar
reviewed
Mar 15, 2023
| estimatedPointsValueLoading: boolean; | ||
| } | ||
|
|
||
| export class WalletPortfolio extends BaseComponent<Props, State> { |
There was a problem hiding this comment.
Use functional component instead of class based please
…into feat/redesign-wallet-page
…into feat/redesign-wallet-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
New wallet view
Shows overall(estimated) wallet value
User can hide or show charts
Users can add or remove hive engine tokens
User can navigate to each token separately (https://ecency.com/@username/wallet/token) to see more transaction info or token info
How to use this feature
Navigate to user profile,
click on wallets then you will see your assets (hive, hive-power, hbd, engine tokens and spk tokens) listed, you can click on each one for more info.
To add more tokens click on add token button, select the token you want to add and confirm. You can also add more than one token. To remove a token from list, you will follow the same procedure and uncheck token.
Screenshot
See video on loom