extras/threadedProcessing.ec: Fixed race condition

- Fixed race condition on initial setup of processing stage thread - Also some attempts at clarifying remaining potential race conditions upon stage termination
ecere · Sep 12, 2023 · 038c620 · 038c620
1 parent 7e96c98
commit 038c620
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/extras/threadedProcessing.ec b/extras/threadedProcessing.ec
@@ -56,6 +56,7 @@ class ProcessingStage
       bool result = false;
       ProcessingTask task;
 
+      mutex.Wait();
       if(!thread)
       {
          thread = threads[0];
@@ -68,7 +69,6 @@ class ProcessingStage
 
       // PrintLn("Thread ", thread.number, " working!");
 
-      mutex.Wait();
       task = tasks.first;
       if(task)
       {
@@ -285,7 +285,10 @@ class ProcessingStage
          {
             semaphore.Release();
             t.Wait();
-            delete threads[i];
+            mutex.Wait();
+            delete t;
+            threads[i] = null;
+            mutex.Release();
          }
       }
       threads.size = 1;