Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing binder links #45

Merged
merged 10 commits into from
Mar 24, 2024
Merged

Fixing binder links #45

merged 10 commits into from
Mar 24, 2024

Conversation

DunklesArchipel
Copy link
Member

@DunklesArchipel DunklesArchipel commented Mar 24, 2024

Checklist

  • Added an entry in doc/news/.
  • Added a test for this change.
  • Adapted the documentation for this change.

Based on: https://github.com/mwouts/jupytext/tree/main/binder

Tested for this branch with: Binder

The binder link will only work when the package is available on conda-forge

@DunklesArchipel DunklesArchipel mentioned this pull request Mar 24, 2024
9 tasks
@DunklesArchipel DunklesArchipel marked this pull request as ready for review March 24, 2024 14:09
Copy link
Contributor

@linuxrider linuxrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the extra bash_kernel?

- pip:
- unitpackage==0.8.0
- bash_kernel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the bash_kernel package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work without it. Not sure what prevented a proper build in previous runs

@DunklesArchipel DunklesArchipel merged commit 5fc7898 into echemdb:main Mar 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants