Fix issue where times are displayed incorrectly in certain areas if php's timezone is different than the system's. #65
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hp's timezone is different than the system's.
|
@ecleese this PR is still valid and appears to work properly (at least on my system). |
|
We should probably allow the user to override the default time zone for those that may have issues accessing their PHP configuration file(#67), but this is a good first step so I'm going to merge it in. |
|
Or not, @ghost can you re-submit this against dev instead of master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses php's date('Z') timezone offset instead of sqlite's 'localtime' modifier to allow for consistent time stamps in the case where php's timezone is different than the system's timezone.