Skip to content

Commit

Permalink
Remove some TODOs from tests after upstream JDT Core fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Kriegisch <[email protected]>
  • Loading branch information
kriegaex committed Dec 14, 2023
1 parent 3b81ea1 commit 696aec6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/features1919/java19/SwitchPatternPreview3OK.java
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static void defaultCanAppearBeforeConstantLabel(Integer i) {
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=579360
* https://github.com/eclipse-jdt/eclipse.jdt.core/issues/587
*
* TODO: reactivate when implemented or move to preview 4 with Java 20.
* DONE: reactivated after fix in Java 21
*/
/*
sealed interface I<T> permits A, B {}
Expand Down
2 changes: 1 addition & 1 deletion tests/features1920/java20/SwitchPatternPreview4OK.java
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ static void nullCanAppearAfterConstantLabel(Integer i) {
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=579360
* https://github.com/eclipse-jdt/eclipse.jdt.core/issues/587
*
* TODO: reactivate when implemented or move to preview 5 with Java 21.
* DONE: reactivated after fix in Java 21
*/
/*
sealed interface I<T> permits D, E {}
Expand Down
2 changes: 0 additions & 2 deletions tests/features1921/java21/SwitchPatternPreview4OK.java
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,6 @@ static void nullCanAppearAfterConstantLabel(Integer i) {
* https://openjdk.java.net/jeps/420#2--Exhaustiveness-of-switch-expressions-and-statements
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=579360
* https://github.com/eclipse-jdt/eclipse.jdt.core/issues/587
*
* TODO: reactivate when implemented or move to preview 5 with Java 21.
*/
sealed interface I<T> permits D, E {}
final static class D<X> implements I<String> {}
Expand Down
2 changes: 2 additions & 0 deletions tests/features199/java18/SwitchPatternPreview2OK.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ static void defaultCanAppearBeforeConstantLabel(Integer i) {
* https://openjdk.java.net/jeps/420#2--Exhaustiveness-of-switch-expressions-and-statements
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=579360
* https://github.com/eclipse-jdt/eclipse.jdt.core/issues/587
*
* DONE: reactivated after fix in Java 21
*/
/*
sealed interface I<T> permits A, B {}
Expand Down

0 comments on commit 696aec6

Please sign in to comment.