Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xstream from 1.4.15 to 1.4.19 #123

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 1, 2022

Bumps xstream from 1.4.15 to 1.4.19.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.15 to 1.4.19.
- [Release notes](https://github.com/x-stream/xstream/releases)
- [Commits](https://github.com/x-stream/xstream/commits)

---
updated-dependencies:
- dependency-name: com.thoughtworks.xstream:xstream
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 1, 2022
@kriegaex
Copy link
Contributor

@aclement, please no not merge this one, because we need the old 1.4.15 version in order to successfully deploy to Sonatype OSSRH and promote to Maven Central when using JDK 16+.

@aclement
Copy link
Contributor

Because the dependabot has obviously not signed the Eclipse CLA, I can't merge these things easily. If we want to do the upgrades, we'd do it manually anyway. I've no real idea how eclipse feels about blessing dependabot PRs.

@kriegaex
Copy link
Contributor

Bad, bad bot! Behave and go sign the ECA! 😂

Yeah, you are right, we would have to re-do those. But at least we get the free suggestions and test runs for each of them. In this case, the test simply does not use the plugin depending on XStream, so I felt like warning you. I could try saying something like:

@dependabot ignore this minor version

But not being a committer here yet, I guess the bot would ignore my request anyway.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 11, 2022

Sorry, only users with push access can use that command.

@kriegaex
Copy link
Contributor

kriegaex commented Mar 8, 2022

Because the dependabot has obviously not signed the Eclipse CLA, I can't merge these things easily. If we want to do the upgrades, we'd do it manually anyway. I've no real idea how eclipse feels about blessing dependabot PRs.

@aclement, now the bot has "signed" the ECA, see this discussion. So from now on we need to be more careful, because we can simply merge its PRs, which I am intending to do regularly in the future. The bot is permitted for all 3 repositories in our project now.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Dec 26, 2022

Superseded by #203.

@dependabot dependabot bot closed this Dec 26, 2022
@dependabot dependabot bot deleted the dependabot/maven/com.thoughtworks.xstream-xstream-1.4.19 branch December 26, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants