Improve ClassPathManager performance, caching unfound entries #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harrisric, you do not seem to have signed the Eclipse Contributor Agreement (ECA) yet. Please do that, otherwise I cannot accept your PR, even after verifying it technically and functionally. Thank you in advance. |
Performance regression test for eclipse-aspectj#306, failing before the enhancement and passing afterward. Signed-off-by: Alexander Kriegisch <[email protected]>
Fixes eclipse-aspectj#306 and adds a few small optimisations. Co-authored-by: Alexander Kriegisch <[email protected]> Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex
force-pushed
the
fix/improve-classpathmanager-performance
branch
from
43c7ea0 to
7cc687a
Compare
|
@harrisric, please note that I added a test in a new commit, then reordered the commits and force-pushed after slightly modifying your commit message. Does that look OK to you? The ECA check now also passes, either due to my co-authorship or because you signed the ECA in the meantime. |
kriegaex
changed the title
Signed-off-by: Alexander Kriegisch <[email protected]>
|
@kriegaex yes, that looks good to me, and yes I have signed the ECA since the PR was first added. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.