Skip to content

Commit

Permalink
Added --feeling-safe option to integration tests
Browse files Browse the repository at this point in the history
Fixes: #971

Local provisioning is considered dangerous since tmt v1.38.0 and
causes the pipeline to fail. In order to be able to run BlueChi
integration tests, lets enable it by setting the environment
variable TMT_FEELING_SAFE via --feeling-safe CLI option in the
GitHub workflow and setting the env variable in packit.
See:
teemtee/tmt#3282
https://tmt.readthedocs.io/en/stable/overview.html#variables

Signed-off-by: Michael Engel <[email protected]>
  • Loading branch information
engelmi committed Oct 28, 2024
1 parent f316832 commit 93644fb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,14 @@ jobs:
tmt lint
cd ..
# Enable local provisioning as this is considered dangerous since tmt v1.38.0
# see https://github.com/teemtee/tmt/pull/3282
- name: Run integration tests
id: run-tests
run: |
cd tests
tmt run -v \
tmt --feeling-safe \
run -v \
-eCONTAINER_USED=integration-test-local \
-eWITH_COVERAGE=1 \
-eLOG_LEVEL=DEBUG \
Expand Down
11 changes: 8 additions & 3 deletions .packit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---

upstream_project_url: https://github.com/eclipse-bluechi/bluechi
issue_repository: https://github.com/eclipse-bluechi/bluechi
specfile_path: bluechi.spec
Expand Down Expand Up @@ -54,11 +53,14 @@ jobs:
labels:
- standard
env:
# Enable local provisioning as this is considered dangerous since tmt v1.38.0
# see https://github.com/teemtee/tmt/pull/3282
TMT_FEELING_SAFE: 1
INSTALL_DEPS: "yes"
targets:
# Run integration tests on Fedora using CS9 containers, because running integrations tests on CS9 using CS9
# containers is very flaky
#
#
# This can be set to fedora-rawhide as soon as the following issue gets resolved:
# https://github.com/containers/podman/issues/22422
- fedora-latest-stable-x86_64
Expand All @@ -68,13 +70,16 @@ jobs:
labels:
- valgrind
env:
# Enable local provisioning as this is considered dangerous since tmt v1.38.0
# see https://github.com/teemtee/tmt/pull/3282
TMT_FEELING_SAFE: 1
INSTALL_DEPS: "yes"
WITH_VALGRIND: "1"

- job: copr_build
trigger: commit
branch: main
owner: '@centos-automotive-sig'
owner: "@centos-automotive-sig"
project: bluechi-snapshot
notifications:
failure_comment:
Expand Down

0 comments on commit 93644fb

Please sign in to comment.