Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test for proxy service propagation is flaky #874

Closed
engelmi opened this issue Apr 10, 2024 · 2 comments
Closed

Integration Test for proxy service propagation is flaky #874

engelmi opened this issue Apr 10, 2024 · 2 comments
Assignees
@ArtiomDivak
Labels
bug Something isn't working jira Issues that are synced to Jira needs research Further research is needed testing This issue adds or improves the testing
Milestone
v0.9

Comments

@engelmi
Copy link
Member

engelmi commented Apr 10, 2024

Describe the bug

The integration test proxy-service-propagate-target-service-failure is flaky.
One of the most recent runs where it failed:
https://github.com/eclipse-bluechi/bluechi/actions/runs/8614446784

Since it seems to randomly fail, a more in-depth analysis is needed here.

To Reproduce

Not sure yet. A more in-depth analysis why the test fails (seemingly randomly) is needed.

Expected behavior

The test proxy-service-propagate-target-service-failure should always pass.
@engelmi engelmi added bug Something isn't working needs research Further research is needed testing This issue adds or improves the testing labels Apr 10, 2024
@engelmi engelmi added this to the v0.9 milestone Apr 12, 2024
@ArtiomDivak
Copy link
Contributor

Please assign me to this issue

@mwperina mwperina added the jira Issues that are synced to Jira label Apr 18, 2024
@engelmi engelmi mentioned this issue Apr 19, 2024
Merged
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 16, 2024
@engelmi
Fix proxy service propagate failure test
eea1957 
Relates to: eclipse-bluechi#874

The proxy service propagates failure integration test has been flaky due to
a race condition where either the job of the requesting service gets canceled
or the requesting service maps the inactive state due to the BindsTo=.
In order to account for this race condition, lets check if either case occurred.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi mentioned this issue Sep 16, 2024
Merged
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 16, 2024
@engelmi
Fix proxy service propagate failure test
0947488 
Relates to: eclipse-bluechi#874

The proxy service propagates failure integration test has been flaky due to
a race condition where either the job of the requesting service gets canceled
or the requesting service maps the inactive state due to the BindsTo=.
In order to account for this race condition, lets check if either case occurred.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 16, 2024
@engelmi
Fix proxy service propagate failure test
1dbd445 
Relates to: eclipse-bluechi#874

The proxy service propagates failure integration test has been flaky due to
a race condition where either the job of the requesting service gets canceled
or the requesting service maps the inactive state due to the BindsTo=.
In order to account for this race condition, lets check if either case occurred.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit to engelmi/bluechi that referenced this issue Sep 16, 2024
@engelmi
Fix proxy service propagate failure test
157a1d0 
Relates to: eclipse-bluechi#874

The proxy service propagates failure integration test has been flaky due to
a race condition where either the job of the requesting service gets canceled
or the requesting service maps the inactive state due to the BindsTo=.
In order to account for this race condition, lets check if either case occurred.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Sep 17, 2024
@engelmi
Fix proxy service propagate failure test
ccf4c2f 
Relates to: #874

The proxy service propagates failure integration test has been flaky due to
a race condition where either the job of the requesting service gets canceled
or the requesting service maps the inactive state due to the BindsTo=.
In order to account for this race condition, lets check if either case occurred.

Signed-off-by: Michael Engel <[email protected]>
@engelmi
Copy link
Member Author

engelmi commented Sep 17, 2024

Fixed in #943. Closing.

@engelmi engelmi closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtiomDivak ArtiomDivak

Labels
bug Something isn't working jira Issues that are synced to Jira needs research Further research is needed testing This issue adds or improves the testing
Projects
None yet
Milestone
v0.9
Development

No branches or pull requests
3 participants
@mwperina @engelmi @ArtiomDivak