Fix integration test race conditions #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
engelmi
force-pushed
the
fix-integration-test-race-conditions
branch
from
3f2b800
to
24b4ce6
Compare
|
/packit test |
|
@mwperina Thanks for the approval! |
|
/packit test |
engelmi
force-pushed
the
fix-integration-test-race-conditions
branch
from
24b4ce6
to
50407af
Compare
|
@mwperina PTAL |
Relates to: eclipse-bluechi#874 The proxy service propagates failure integration test has been flaky due to a race condition where either the job of the requesting service gets canceled or the requesting service maps the inactive state due to the BindsTo=. In order to account for this race condition, lets check if either case occurred. Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
fix-integration-test-race-conditions
branch
from
a11d29e
to
36f1ac8
Compare
|
/packit test |
|
The packit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
Fix proxy service propagate failure test
Relates to: #874
The proxy service propagates failure integration test has been flaky due to a race condition where either the job of the requesting service gets canceled or the requesting service maps the inactive state due to the BindsTo=. In order to account for this race condition, lets check if either case occurred.
Fix race condition in status watch testIn the integration test for the bluechictl status watch command two parallel processes are run - one producing output, the second checking it. To ensure that the processing part can collect all the output from process one, a short delay is added.