Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Integration Tests in multihost mode #879

Closed
engelmi opened this issue Apr 16, 2024 · 2 comments
Closed

Failing Integration Tests in multihost mode #879

engelmi opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working jira Issues that are synced to Jira needs research Further research is needed testing This issue adds or improves the testing
Milestone

Comments

@engelmi
Copy link
Member

engelmi commented Apr 16, 2024

Describe the bug

#878 added the (manually triggered) Workflow for running BlueChi's integration tests in multihost mode on testing farm. When running those on Fedora-rawhide, a bunch of tests are failing due to Timeout (as far as I've seen during a quick check), see for example:
Triggered GitHub Action: https://github.com/eclipse-bluechi/bluechi/actions/runs/8705253129/job/23875254490
Testing Farm Run: http://artifacts.osci.redhat.com/testing-farm/da6aff4d-e39b-4696-a1f9-3658cd961afd/

We need to investigate the root cause. This most likely doesn't affect anything in BlueChi itself, but only the integration tests (e.g. stability of checking conditions, etc.).

To Reproduce

Trigger the integration tests to run on testing farm in multihost mode for Fedora-Rawhide (e.g. via GH Workflow).

@engelmi engelmi added bug Something isn't working needs research Further research is needed testing This issue adds or improves the testing labels Apr 16, 2024
@engelmi engelmi added this to the v0.9 milestone Apr 16, 2024
@dracher
Copy link
Contributor

dracher commented Apr 17, 2024

i will take this issue

@mwperina mwperina added the jira Issues that are synced to Jira label Apr 17, 2024
engelmi added a commit to engelmi/bluechi that referenced this issue Apr 17, 2024
Relates to: eclipse-bluechi#879
Relates to: eclipse-bluechi#883
Relates to: eclipse-bluechi#884

This is a temporary fix to get BlueChi with its SELinux policy
to work again as it is currently broken. As soon as the policy
is refined (eclipse-bluechi#883)
this change can be reversed and the policy enforced again.

Signed-off-by: Michael Engel <[email protected]>
@engelmi
Copy link
Member Author

engelmi commented Apr 17, 2024

After investigation, it seems the test failures are related to the latest change in the SELinux policy (#850).
This will be tackled in #883. Therefore closing this issue in favor of #883 and #884.

@engelmi engelmi closed this as completed Apr 17, 2024
engelmi added a commit that referenced this issue Apr 18, 2024
Relates to: #879
Relates to: #883
Relates to: #884

This is a temporary fix to get BlueChi with its SELinux policy
to work again as it is currently broken. As soon as the policy
is refined (#883)
this change can be reversed and the policy enforced again.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

When creating files, we first keep track of them in
the list for newly created ones. If a file is already
in that list and another file with the same path
(dir+name) is created we keep create a backup and
track it.
For clean-up we need to reverse that order - first
restore tracked backup files and then remove created
files. This ensures that there are no dangling files.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

In order to avoid failing mkdir calls on subsequent
tests for the bluechi_machine_lib, an active check is
being made. If it doesn't exist yet, we create the
directory and the library files. These files are not
tracked and thus not deleted after a test. This way,
we only create the lib once.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

The client for the podman container seems to
concatenate stderr and stdout in its output parameter.
In the SSH client stderr and stdout are different
return variables. In order to not break the `exec_run` API
of the Client class and still get a uniform behavior of
both clients, lets concat stderr and stdout in the SSH client.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

When creating files, we first keep track of them in
the list for newly created ones. If a file is already
in that list and another file with the same path
(dir+name) is created we keep create a backup and
track it.
For clean-up we need to reverse that order - first
restore tracked backup files and then remove created
files. This ensures that there are no dangling files.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

In order to avoid failing mkdir calls on subsequent
tests for the bluechi_machine_lib, an active check is
being made. If it doesn't exist yet, we create the
directory and the library files. These files are not
tracked and thus not deleted after a test. This way,
we only create the lib once.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

The client for the podman container seems to
concatenate stderr and stdout in its output parameter.
In the SSH client stderr and stdout are different
return variables. In order to not break the `exec_run` API
of the Client class and still get a uniform behavior of
both clients, lets concat stderr and stdout in the SSH client.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

When creating files, we first keep track of them in
the list for newly created ones. If a file is already
in that list and another file with the same path
(dir+name) is created we keep create a backup and
track it.
For clean-up we need to reverse that order - first
restore tracked backup files and then remove created
files. This ensures that there are no dangling files.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

In order to avoid failing mkdir calls on subsequent
tests for the bluechi_machine_lib, an active check is
being made. If it doesn't exist yet, we create the
directory and the library files. These files are not
tracked and thus not deleted after a test. This way,
we only create the lib once.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

The client for the podman container seems to
concatenate stderr and stdout in its output parameter.
In the SSH client stderr and stdout are different
return variables. In order to not break the `exec_run` API
of the Client class and still get a uniform behavior of
both clients, lets concat stderr and stdout in the SSH client.

Signed-off-by: Michael Engel <[email protected]>
engelmi added a commit that referenced this issue Apr 19, 2024
Relates to: #879

Signed-off-by: Michael Engel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira Issues that are synced to Jira needs research Further research is needed testing This issue adds or improves the testing
Projects
None yet
Development

No branches or pull requests

3 participants