added file cleanup for multihost tests #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
engelmi
force-pushed
the
added-cleanup-to-integration-tests
branch
4 times, most recently
from
a18550a
to
b66390a
Compare
Relates to: eclipse-bluechi#662 Added a tag on the root main.fmf to mark all tests by default to be able to run in a multihost setting. Certain tests that exceed the available number of hosts (>3) are disabled for now. Signed-off-by: Michael Engel <[email protected]>
Relates to: eclipse-bluechi#662 In order to run all tests on a set of provisioned hosts, the state of the host needs to be restored after each test run. This includes: - removing all added files - restoring all changed files - stopping all systemd units and reset failed ones (incl. bluechi) By keeping track of these operations, the test class is able to execute respective cleanup tasks on the hosts. Therefore, the cleanup from machine class has been moved to the ssh test class. The container test class still only removes the created containers. Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
added-cleanup-to-integration-tests
branch
from
b66390a
to
7075439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #662
In order to run all tests on a set of provisioned hosts, the state of the host needs to be restored after each test run. This includes:
By keeping track of these operations, the test class is able to execute respective cleanup tasks on the hosts. Therefore, the cleanup from machine class has been moved to the ssh test class. The container test class still only removes the created containers.
Also, added a tag on the root main.fmf to mark all tests by default to be able to run in a multihost setting. Certain tests that exceed the available number of hosts (>3) are disabled for now. And fixed/improved some of the integration tests.
Testing this change:
In order to test this on testing farm (GH CI with containers is automatic), a dedicated branch has been created:
https://github.com/engelmi/bluechi/tree/added-cleanup-to-integration-test-experiment
It changes the plan
tier0.fmfto use a multihost setup and filters only for tests with thetag: multihost- which is set for all tests except some few that exceed the maximum number of nodes (>3).Request to start on testing farm: (an exported API token is required)
And here are the results:
http://artifacts.osci.redhat.com/testing-farm/57eb8333-a3d6-4239-8df8-fce66840f4ad/