Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ANSI escape sequences from command outputs #956

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Oct 4, 2024

Some commands, which are executed as a part of tests (for example
"systemctl is-enabled"), return output containing ANSI escape sequence.
Unfortunately tmt 1.37.0 started to check valid characters as a part of
junit report and those character caused failures. So this patch removes
ANSI escape sequences from logged data, so report in tmt 1.37.0 is
created successfully.

Signed-off-by: Martin Perina [email protected]

Some commands, which are executed as a part of tests (for example
"systemctl is-enabled"), return output containing ANSI escape sequence.
Unfortunately tmt 1.37.0 started to check valid characters as a part of
junit report and those character caused failures. So this patch removes
ANSI escape sequences from logged data, so report in tmt 1.37.0 is
created successfully.

Signed-off-by: Martin Perina <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 83.538%. remained the same
when pulling 39a5b04 on remove-control-chars-from-output
into afd5ac2 on main.

@mwperina
Copy link
Member Author

mwperina commented Oct 4, 2024

/packit retest-failed

2 similar comments
@mkemel
Copy link
Member

mkemel commented Oct 6, 2024

/packit retest-failed

@mwperina
Copy link
Member Author

mwperina commented Oct 6, 2024

/packit retest-failed

Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit bbc9ae4 into main Oct 7, 2024
22 checks passed
@mwperina mwperina deleted the remove-control-chars-from-output branch October 7, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants