Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when running test with tmt.discover.prune=true #965

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

dracher
Copy link
Contributor

@dracher dracher commented Oct 23, 2024

when tmt prune enabled, below items will not be transfered

  • bluechi/tests/scripts
  • bluechi/tests/containers
  • bluechi/tests/bluechi_machine_lib
  • bluechi/tests/bluechi_test

when tmt prune enabled, below items will not be transfered

  - bluechi/tests/scripts
  - bluechi/tests/containers
  - bluechi/tests/bluechi_machine_lib
  - bluechi/tests/bluechi_test
@coveralls
Copy link

coveralls commented Oct 23, 2024

Coverage Status

coverage: 83.301% (+0.02%) from 83.286%
when pulling 77588f6 on dracher:fix_for_tmt-prune
into 164afb1 on eclipse-bluechi:main.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please add a suggested comment

tests/tests/main.fmf Show resolved Hide resolved
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we could exclude some directories (tests are run on only one machine/node, for example), but we can optimize in a separate PR. Lets get this merged.

@mwperina mwperina merged commit e0107bf into eclipse-bluechi:main Oct 24, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants