Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeouts for bash exec commands from tests #974

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mkemel
Copy link
Member

@mkemel mkemel commented Oct 31, 2024

Some tests that have timeouts for specific bash commands fail with timeout on slower hardware. As we have configurable timeouts for test setup, execution and collecting results - there is no need in timeout for specific commands.

Resolves: #973

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some tests that have timeouts for specific bash commands fail with
timeout on slower hardware. As we have configurable timeouts for test
setup, execution and collecting results - there is no need in timeout
for specific commands.

Resolves: eclipse-bluechi#973
Signed-off-by: Mark Kemel <[email protected]>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix pylint issues, but other than that it looks good to me

@coveralls
Copy link

coveralls commented Oct 31, 2024

Coverage Status

coverage: 83.106%. remained the same
when pulling bab4fe1 on mkemel:remove_test_timeouts
into 71be67d on eclipse-bluechi:main.

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel mkemel requested a review from mwperina October 31, 2024 11:02
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel mkemel merged commit ada5cf5 into eclipse-bluechi:main Oct 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove specific tests timeouts and rely on the whole test timeout
4 participants