-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timeouts for bash exec commands from tests #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some tests that have timeouts for specific bash commands fail with timeout on slower hardware. As we have configurable timeouts for test setup, execution and collecting results - there is no need in timeout for specific commands. Resolves: eclipse-bluechi#973 Signed-off-by: Mark Kemel <[email protected]>
e2eae80
to
bab4fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix pylint issues, but other than that it looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some tests that have timeouts for specific bash commands fail with timeout on slower hardware. As we have configurable timeouts for test setup, execution and collecting results - there is no need in timeout for specific commands.
Resolves: #973