Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back @theia/messages dependency to show toast messages #1086

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

bhufmann
Copy link
Collaborator

@bhufmann bhufmann commented Jun 21, 2024

This was accidentally removed during streamling of the example app. See commit 4c58c03

Signed-off-by: Bernd Hufmann [email protected]

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Bernd!

I added one comment about a minor optional change that could be done.

This was accidentally removed during streamling of the example app.
See commit 4c58c03

Signed-off-by: Bernd Hufmann <[email protected]>
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Bernd!

@bhufmann bhufmann merged commit 3bcf1b5 into eclipse-cdt-cloud:master Jun 21, 2024
7 checks passed
@bhufmann bhufmann deleted the fix-toast-messages branch June 21, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants