Upgrade ag-grid, perform yarn upgrade #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
5 times, most recently
from
00d423c
to
dcf6313
Compare
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
dcf6313
to
f7cb1e9
Compare
marcdumais-work
changed the title
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
f7cb1e9
to
c0de37b
Compare
|
EF IP Tickets opened for the dependencies failing the license check:
|
bhufmann
requested changes
Aug 23, 2024
|
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
c0de37b
to
75a1898
Compare
bhufmann
reviewed
Aug 26, 2024
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
c946c61
to
d645971
Compare
done - down to 3 commits that I think are logical increments |
Bumps [ag-grid-community](https://github.com/ag-grid/ag-grid) from 28.2.1 to 32.0.1. - [Release notes](https://github.com/ag-grid/ag-grid/releases) - [Commits](ag-grid/ag-grid@v28.2.1...v32.0.1) --- updated-dependencies: - dependency-name: ag-grid-community dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Adapt to later ag-grid version Dependabot opened a PR to suggest we update our "ag-grid" dependencies. However, the PR did not build, because ir proposes we jump forward 3 major releases forward, and there were API changes between that version and what we use. In consequence, it's necessary to make changes in how we import and use this dependency. Here are a few highlights: - Switch to use the "@ag-grid-community/*" modules - Theme ag-theme-balham.css: both light and dark themes are now bundled in the same file - ColumnApi has been deprecated, then removed. its features have been moved to the GridApi, which we now need to use - need to explicitly import and register infinte-row-model module, before we can use it to scroll in our tables: @ag-grid-community/infinite-row-model - no longer possible to set data source using "api.setDatasource([...])". now using "api.setGridOption('datasource', [...])" instead also: Fix formatting issue reported by yarn format:check ag-grid table: disable column sort, filter buttons Defaults have probably changed since the last major version we used, so we now need to explicitly disable column sorting and suppress the column filter button, when configuring the table columns, to keep the same features we had before. Temporarily disable most tests in table-components.test.tsx The upgrade of ag-grid had made unavailable some of the APIs that are used in this test file. e.g. it's no longer possible to create a column using "new Column([...])". Same for creating a GridApi object. I'm not sure if we can work-around these new limitations or if we will need to redesign these tests. Co-authored-by: Marc Dumais <[email protected]> Signed-off-by: Marc Dumais <[email protected]>
Align to typescript 4.9.5 update @fortawesome/react-fontawesome to 0.2.x to remove ReactDom warning Add license check exclusion for [email protected]: Also took the opportunity to remove a previous exclusion entry that's no longer relevant Pin 3PP rimraf to ^5.0.0: Version ^6.0.0 required node 20, which we have not yet adopted in this repository Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
d645971
to
14682d2
Compare
New version pushed that contains 2 commits |
marcdumais-work
force-pushed
the
upgrade-ag-grid
branch
from
14682d2
to
46ec329
Compare
bhufmann
approved these changes
Aug 27, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ag-grid upgrade
Adapt to later ag-grid version
Dependabot opened a PR to suggest we update our "ag-grid" dependencies.
However, the PR did not build, because ir proposes we jump forward 3
major releases forward, and there were API changes between that version
and what we use.
In consequence, it's necessary to make changes in how we import and use this
dependency. Here are a few highlights:
the same file
to the GridApi, which we now need to use
use it to scroll in our tables: @ag-grid-community/infinite-row-model
using "api.setGridOption('datasource', [...])" instead
TODO:
the tests inAt the suggestion of @MatthewKhouzam I have disabled the failing tests for the moment. See related commit for more details. update: follow-up issue, to fix the tests: Re-enable table-components.test.tsx tests #1100packages/react-components/src/components/__tests__/table-renderer-components.test.tsxdo not pass anymore - they were relying on having access to thegridApi/columnApiobjects, which has been restricted in later versions ofag-grid.the vscode trace viewer pulls the ag-grid packages. At first look it seems to be just to use the .css files [1], but to be safe it's probably better to test the vscode extension using this PR's version of the "react components" package.Seems to work ok: try this draft PR locally: Upgrade traceviewer* packages to v0.2.6, that include upgraded ag-grid vscode-trace-extension#262 . Note: it assumes repotheia-trace-extensionsits at the same level is itself and has been build using this PR here.[1]:
if that's the case, I think the packages can be replaced by the much smallerConfirmed that vscode-trace-extension only requires .css files, provided now by npm package@ag-grid-community/styles@ag-grid-community/styles.yarn upgrade
yarn audit before:
yarn audit after: