-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #265 #267
Fix issue #265 #267
Conversation
Wait for fileOpenHandler to finish, before refreshing the trace explorer context. Signed-off-by: Greg Savin <[email protected]>
Thanks for the contribution. In order to merge this PR you need to sign the ECA as described in the contribution guide. Please follow the instructions there. Thanks. |
The ECA check now passes |
Thanks, yes I signed the ECA yesterday after first seeing the check not passing; glad that the check is now passing. |
@bhufmann That one seems used when using the "Open Trace" command. That one seems to work correctly, but I';m not sure why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change is small and elegant! I tested with my own extension that contributes a custom command that executes command "traces.openTraceFile" to open a trace file I have locally. I also tested without an extension, as suggested by @bhufmann in the comments on the corresponding issue. In both cases I was able reproduce the issue using the latest master branch, and in both cases, this PR branch fixed the problem.
Thanks @GregSavin for this contribution ! I believe we will need a second committer approval before we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, too. Thanks!
@GregSavin I'm not sure if you consume this extension from the VS Marketplace and/or openvsx, but FYI I think we will likely do a release soon that includes your fix. Probably after the following PR is merged: |
Thanks all! |
Wait for fileOpenHandler to finish, before refreshing the trace explorer context.