-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker example #273
base: master
Are you sure you want to change the base?
Add docker example #273
Conversation
Add an example showing how to create a docker image that contains a Theia-based application with the vscode-trace-extension. Signed-off-by: Francesco Robino <[email protected]>
I'm not sure if this contribution might fit-in better in repo Alternatively, since neither example application directly depend on the content in either repository, we might consider creating a new repo for them both, e.g. "Trace Viewer example applications" ? P.S. one potential argument to have this contribution in this repo here: we would need to try to confirm, but it's possible that the repo's tests, currently used against openvscode server running the vscode trace viewer, could be easily re-used on the containerized example Theia app running the same. |
@marcdumais-work not sure if this can be used for the tests you mention above, mainly because the Theia application is not picking the "latest vscode-trace-extension master" but one of the released prebuilt vsix packages. I think it belongs to this repo just to provide an example of how the artifacts produced by this repo can be used. |
I agree - but the goal would not be to test the trace viewer extension (it's already being tested), but rather to test the example application itself, to detect if it breaks. It's just a little bonus, if we can do that re-using the existing tests in the repo, like we did for the example application in theia-trace-extension. |
I think that this docker example should be in the |
@bhufmann before following your advice, I'd like to understand the rationale of having this example in the theia-trace-extension repo. What is proposed in this pull request is an example of how to use the artifact created by this repo (vscode-trace-extension). That's why I contributed it to this repo. The fact that the artifact is wrapped in a Theia application does not sound as a reason to have it in the theia-trace-extension repo. Maybe I should change it to a VSCode application, but then, would that really make a difference? Aren't we just changing the way we wrap an artifact created by the vscode-trace-extension repo? Thanks for the explanation and help in advance! |
Author: Frallax Original PR (opened on another repo): eclipse-cdt-cloud/vscode-trace-extension#273 Signed-off-by: Marc Dumais <[email protected]>
Author: Frallax Original PR (opened on another repo): eclipse-cdt-cloud/vscode-trace-extension#273 Signed-off-by: Marc Dumais <[email protected]>
Add an example showing how to create a docker image that contains a Theia-based application with the vscode-trace-extension.