Support arguments and working directory in launching Core Build proje…

[ewaterlander]

…cts for Local

Added the CArgumentsTab to the Core Build launch configuration for the Local target. This enables users to set command line arguments and specify a working directory.

[ewaterlander]

[ewaterlander]

Hi @betamaxbandit ,
would you like to review?

[ewaterlander]

Note this fixes all 4 flavors of Core Build projects: CMake, Makefile, Autotools, Arduino.

[betamaxbandit]

Hi @ewaterlander ,
Yes I'll review this. Hopefully will get to it soon.
Cheers John

[ewaterlander]

Hi @ewaterlander , Yes I'll review this. Hopefully will get to it soon. Cheers John

Thanks!
I think the failing tests are not caused by my change. I see no relation. I think these failures are caused by timeouts.

[jonahgraham]

Please see #816 the test fails are not caused by your change, but rather by some change on the GitHub runners.

[ewaterlander]

Should I trigger a new build?
What's actually the best way to do that? What I would do now is a git amend with a small change of the commit message and then a push -f.

[betamaxbandit]

Should I trigger a new build? What's actually the best way to do that? What I would do now is a git amend with a small change of the commit message and then a push -f.

Hi @ewaterlander ,
yes that's what I did the other day for mine.

[ewaterlander]

Build is still broken.

[jonahgraham]

I re triggered the licensing check, the 8 errors/60 fails is #816

[betamaxbandit]

LGTM

[ewaterlander]

Hi,
Is merging on hold? What should I do?

[betamaxbandit]

Hi, Is merging on hold? What should I do?

Hi @ewaterlander ,
I also have some patches which I'm waiting to be merged, so I expect @jonahgraham may be away on vacation.

Cheers John

[ewaterlander]

I retriggerd a build. I hope this PR can get merged soon.

[ewaterlander]

I retriggerd a build. I hope this PR can get merged soon.

Build failed with these errors:

Error: Failed to resolve target definition file:/work/releng/org.eclipse.cdt.target/cdt.target: Failed to load p2 metadata repository from location https://download.eclipse.org/eclipse/updates/4.33-I-builds/: No repository found at https://download.eclipse.org/eclipse/updates/4.33-I-builds.
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.