-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a warning notification on fetch token error when starting a work… #1179
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
/retest |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
9df5749
to
d57dacd
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
3 similar comments
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
d57dacd
to
ce6e32e
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
81447da
to
e7fe0bf
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts
Outdated
Show resolved
Hide resolved
@olexii4 @akurinnoy since Igor is on PTO this week, we should either merge it as is if in principal all good, or somebody from dashboard side need to provide update on this PR with required changes |
@ibuziuk It was a one day PTO so I am available from today. I will address the pr comments today. |
dfb4e13
to
df19e06
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
df19e06
to
d91ca1c
Compare
New changes are detected. LGTM label has been removed. |
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5352745
to
6916e23
Compare
6916e23
to
0096722
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1179 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1179", name: che-dashboard}]}}]" |
Build 3.17 :: dashboard_3.x/544: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7706: Console, Changes, Git Data |
…space
What does this PR do?
Show a warning notification on fetch token error when starting a workspace.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23076
Is it tested? How?
see eclipse-che/che-server#715
Release Notes
Docs PR