return devfile v2 as a default devfile #702
Conversation
| () -> | ||
| newDto(FactoryDevfileV2Dto.class) | ||
| .withDevfile(Map.of("schemaVersion", "2.3.0")) | ||
| .withV(CURRENT_VERSION) |
There was a problem hiding this comment.
what is the CURRENT_VERSION stand for ?
There was a problem hiding this comment.
This is Che specific factory API version constant. CURRENT_VERSION = "4.0"
| .orElseGet( | ||
| () -> | ||
| newDto(FactoryDevfileV2Dto.class) | ||
| .withDevfile(Map.of("schemaVersion", "2.3.0")) |
There was a problem hiding this comment.
@vinokurig could you please clarify if we removed everything related to devfile v1? or this is smth. to be done separately?
No, Here is the issue to clean up the code base: eclipse-che/che#23043 |
|
/retest |
1 similar comment
|
/retest |
|
Verified on Eclipse Che with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.16 :: server_3.x/348: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7296: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4772: Console, Changes, Git Data |
|
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7275: server : 3.x :: Build 62825546 : quay.io/devspaces/server-rhel8:3.16-8 |
|
Build 3.16 :: update-digests_3.x/7118: Console, Changes, Git Data |
|
Build 3.16 :: server_3.x/348: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7296 triggered |
|
Build 3.16 :: operator-bundle_3.x/3351: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7297: Console, Changes, Git Data |
|
Build 3.16 :: push-latest-container-to-quay_3.x/4773: Console, Changes, Git Data |
|
Build 3.16 :: copyIIBsToQuay/2709: Console, Changes, Git Data |
|
Build 3.16 :: sync-to-downstream_3.x/7297: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7276 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.16 :: operator-bundle_3.x/3351: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7297 triggered |
|
Build 3.16 :: dsc_3.x/1948: Console, Changes, Git Data |
|
Build 3.16 :: update-digests_3.x/7118: Detected new images: rebuild operator-bundle |
|
Build 3.16 :: dsc_3.x/1948: 3.16.0-CI |
What does this PR do?
Return devfile version 2 as a default devfile.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23007
How to test this PR?
see eclipse-che/che#23007
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.