Use HTTP response status code to check gitlab repositories accessibility #741
Conversation
|
/retest |
|
Verified on Eclipse Che with The functionality works properly. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
Build 3.18 :: server_3.x/373: Console, Changes, Git Data |
…ity (#741) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
…ity (#741) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
…ity (#741) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
|
Build 3.18 :: sync-to-downstream_3.x/8112: Console, Changes, Git Data |
…ity (#741) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
…ity (#741) (#742) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
…ity (#741) (#743) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
|
Build 3.18 :: push-latest-container-to-quay_3.x/5025: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8189: server : 3.x :: Build 65955846 : quay.io/devspaces/server-rhel8:3.18-12 |
|
Build 3.18 :: update-digests_3.x/8013: Console, Changes, Git Data |
|
Build 3.18 :: server_3.x/373: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8112 triggered |
|
Build 3.18 :: operator-bundle_3.x/3895: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8113: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8190: devspaces-operator-bundle : 3.x :: Failed in 65956395 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Improve the
isPublicRepository()function in theGitlabAuthorizingFileContentProviderclass to check the http response status code. The previous way with theurlFetcherdoes not work because gitlab server returns a content of an html page with credentials input instead of an error.Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7608
How to test this PR?
quay.io/eclipse/che-server:pr-741See: workspace start fails with the expected error message:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
With this fix workspace start from a private gitlab repository will interrupt with an error if no token is present.
Reviewers
Reviewers, please comment how you tested the PR when approving it.