Add 'CppDevFileAPI' E2E test #23289
Merged
Add 'CppDevFileAPI' E2E test #23289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artaleks9
requested review from
musienko-maxim and
dmytro-ndp
as code owners
artaleks9
requested review from
dmytro-ndp
and removed request for
dmytro-ndp and
musienko-maxim
dmytro-ndp
reviewed
Dec 16, 2024
| const toolsComponent: any = YAML.parse(devfileContent).components.find((component: any): boolean => component.name === 'tools'); | ||
| const containerName: string = toolsComponent ? toolsComponent.name : 'Component not found'; | ||
| Logger.info(`container from components section of Devfile:: ${containerName}`); | ||
| runCommandInBash = `cd ${workDirPath} && ${buildCommand}`; |
There was a problem hiding this comment.
It's important to test build command extracted from C++ sample devfile together with workDir property, not hard-coded in the test itself.
Example of command extraction can be found in the in the code https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/api/PythonDevFileAPI.spec.ts#L63-L64
dmytro-ndp
reviewed
Dec 16, 2024
| expect(output.code).eqls(0); | ||
| expect(output.stdout.trim()).contains('Build complete'); | ||
| Logger.info('Check run command'); | ||
| runCommandInBash = `cd ${workDirPath} && ${runCommand}`; |
There was a problem hiding this comment.
It's important to test run command extracted from C++ sample devfile together with workDir property, not hard-coded in the test itself.
Example of command extraction can be found in the in the code https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/api/PythonDevFileAPI.spec.ts#L63-L64
dmytro-ndp
reviewed
Dec 16, 2024
| let devWorkspaceConfigurationHelper: DevWorkspaceConfigurationHelper; | ||
| let devfileContext: DevfileContext; | ||
| let devfileContent: string = ''; | ||
| const workDirPath: string = 'c-plus-plus/strings'; |
There was a problem hiding this comment.
it should be extracted from the devfile yaml for particular command
See an example in https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/api/PythonDevFileAPI.spec.ts#L63
dmytro-ndp
reviewed
Dec 16, 2024
| let devfileContext: DevfileContext; | ||
| let devfileContent: string = ''; | ||
| const workDirPath: string = 'c-plus-plus/strings'; | ||
| const buildCommand: string = 'rm -f bin.out && g++ -g "knuth_morris_pratt.cpp" -o bin.out && echo "Build complete"'; |
There was a problem hiding this comment.
Build command should be extracted from the devfile yaml of C++ sample.
See an example in https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/api/PythonDevFileAPI.spec.ts#L64
dmytro-ndp
reviewed
Dec 16, 2024
| let devfileContent: string = ''; | ||
| const workDirPath: string = 'c-plus-plus/strings'; | ||
| const buildCommand: string = 'rm -f bin.out && g++ -g "knuth_morris_pratt.cpp" -o bin.out && echo "Build complete"'; | ||
| const runCommand: string = './bin.out'; |
There was a problem hiding this comment.
Run command should be extracted from the devfile yaml of C++ sample.
See an example in https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/api/PythonDevFileAPI.spec.ts#L64
|
@dmytro-ndp I would do so, if C++ sample had
|
|
Thank you for the explanation, @artaleks9 ! |
|
| It would be appreciated if you could implement the code which extracts the commands to execute from .vscode/tasks.json file in the project. Done. |
SkorikSergey
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CppDevFileAPItest to check command execution ofcppsampleScreenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Run the
CppDevFileAPI.spec.tsas usualPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.