Remove pointless generics from PeakDetector #2020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
ungeneric-peakdetector
branch
from
2d7923f to
67f3b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it seems to be applied incorrectly here.
IProcessingInfohas no result other than messages for this class, so there is no point in connecting it to thePeakDetectorclasses. It only leads to result types likePeakDetectorCSD<?, ?, ?>with three unbounded wildcards, which doesn't help with type safety in any way. I find it verbose and hard to read. TheBasePeakDetectoralready solves the problem with inheritance and the CSD/MSD/WSD suffix with casting to the correct type/interface.