Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle iterable Criterion operandRight #3218

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 23, 2023

What this PR changes/adds

Make JsonObjectToCriterionDtoTransformer handle in operator correctly

Why it does that

support "in" operator

Further notes

  • cleaned up some unused methods

Linked Issue(s)

Fix #3216

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Jun 23, 2023
@ndr-brt ndr-brt added the api Feature related to the (REST) api label Jun 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.26 ⚠️

Comparison is base (36aa899) 65.37% compared to head (dd9110d) 65.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
- Coverage   65.37%   65.11%   -0.26%     
==========================================
  Files         837      837              
  Lines       16822    16777      -45     
  Branches      926      918       -8     
==========================================
- Hits        10998    10925      -73     
- Misses       5452     5487      +35     
+ Partials      372      365       -7     
Impacted Files Coverage Δ
...main/java/org/eclipse/edc/spi/query/Criterion.java 25.80% <0.00%> (ø)
...nld/spi/transformer/AbstractJsonLdTransformer.java 15.22% <0.00%> (+2.88%) ⬆️
...ansformer/JsonObjectToCriterionDtoTransformer.java 100.00% <100.00%> (+20.00%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndr-brt ndr-brt merged commit 6afc66d into eclipse-edc:main Jun 23, 2023
24 of 26 checks passed
@ndr-brt ndr-brt deleted the 3126-handle-iterable-criterion-rigth-operand branch June 23, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonObjectToCriterionDtoTransformer can not be Used to Create Criterions using the in Operator
3 participants