Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): implement GET /id transfer process endpoint #3234

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

Adds a method findById to the TransferProcessProtocolService, that takes a ClaimToken as parameter and returns a transfer process only if the requesting party is authorized. Using this method, implements the GET /id endpoint in the DspTransferProcessApiController.

Why it does that

To support the protocol specification

Further notes

Adds a second validateRequest() method to the ContractValidationService, that checks whether a requesting participant is authorized for a contract agreement, but does not perform policy evaluation.

Linked Issue(s)

Closes #2761

@ronjaquensel ronjaquensel added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Jun 26, 2023
@ronjaquensel ronjaquensel added this to the Milestone 10 milestone Jun 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 88.46% and project coverage change: +0.01 🎉

Comparison is base (070aa11) 65.69% compared to head (c444022) 65.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
+ Coverage   65.69%   65.71%   +0.01%     
==========================================
  Files         840      840              
  Lines       16787    16805      +18     
  Branches      917      918       +1     
==========================================
+ Hits        11028    11043      +15     
- Misses       5392     5394       +2     
- Partials      367      368       +1     
Impacted Files Coverage Δ
...pi/controller/DspTransferProcessApiController.java 92.50% <76.92%> (-2.17%) ⬇️
...ract/validation/ContractValidationServiceImpl.java 86.00% <100.00%> (+0.73%) ⬆️
...ferprocess/TransferProcessProtocolServiceImpl.java 98.87% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronjaquensel ronjaquensel merged commit 20c366a into eclipse-edc:main Jun 27, 2023
24 checks passed
@ronjaquensel ronjaquensel deleted the feat/2761-protocol-transfer-findById branch June 27, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocol: add method for finding TP to protocol service
4 participants