Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: permit to configure fs vault with configuration file #3307

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 17, 2023

What this PR changes/adds

Uses getSetting where possible instead of propOrEnv

Why it does that

permit vault to be configured via configuration (!)

Further notes

Linked Issue(s)

Closes #1106

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Jul 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.00% and no project coverage change.

Comparison is base (112ade7) 71.63% compared to head (f86c67d) 71.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3307   +/-   ##
=======================================
  Coverage   71.63%   71.64%           
=======================================
  Files         831      831           
  Lines       16681    16679    -2     
  Branches      953      953           
=======================================
  Hits        11949    11949           
+ Misses       4336     4334    -2     
  Partials      396      396           
Impacted Files Coverage Δ
...eclipse/edc/vault/filesystem/FsVaultExtension.java 0.00% <0.00%> (ø)
...edc/util/configuration/ConfigurationFunctions.java 66.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndr-brt ndr-brt merged commit b62b87f into eclipse-edc:main Jul 19, 2023
23 checks passed
@ndr-brt ndr-brt deleted the 1106-fix-configs branch July 19, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystore configs can only be provided via env variable
3 participants