feat: register additional JSON-LD files via config #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
approved these changes
Jul 20, 2023
ndr-brt
reviewed
Jul 20, 2023
extensions/common/json-ld/src/main/java/org/eclipse/edc/jsonld/JsonLdExtension.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/2951_load_file_doc_resolver_from_config
branch
from
39264b4
to
0103710
Compare
paullatzelsperger
force-pushed
the
feat/2951_load_file_doc_resolver_from_config
branch
from
0103710
to
fbd9143
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extensions/common/json-ld/src/main/java/org/eclipse/edc/jsonld/JsonLdExtension.java
Fixed
Show fixed
Hide fixed
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3317 +/- ##
==========================================
+ Coverage 71.91% 71.93% +0.01%
==========================================
Files 810 810
Lines 16509 16524 +15
Branches 962 965 +3
==========================================
+ Hits 11872 11886 +14
Misses 4236 4236
- Partials 401 402 +1
☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
Jul 21, 2023
| * converts a map entry, that looks like "something.url" -> https://foo.bar, into a map entry, that looks like | ||
| * "something" -> ("url" -> "https://foo.bar") and adds it to an existing map | ||
| */ | ||
| private void split(Map<String, Map<String, String>> targetMap, Map.Entry<String, String> entry) { |
| return service; | ||
| } | ||
|
|
||
| private void registerCachedDocumentsFromConfig(ServiceExtensionContext context, TitaniumJsonLd service) { | ||
| Map<String, Map<String, String>> tempMappings = new HashMap<>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds the possibility to register additional files with the
CachedDocumentLoadervia config entries, e.g.:edc.jsonld.document.foo.path=/tmp/path/to/doc.jsonedc.jsonld.document.foo.url=https://foo.com/doc.jsonldWhy it does that
configurability and flexibility in downstream projects
Further notes
aConfig#getRelativeEntries(String, boolean)method was added to allow stripping away thebasePathfrom resulting entries, returningfoo.pathinstead ofedc.jsonld.document.foo.pathLinked Issue(s)
Closes #2951
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.