-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: uniform in-memory and sql store implementations #3330
refactor: uniform in-memory and sql store implementations #3330
Conversation
*/ | ||
public class CriterionToAssetPredicateConverterImpl extends CriterionToPredicateConverterImpl implements CriterionToAssetPredicateConverter, CriterionToPredicateConverter { | ||
|
||
public Object property(String key, Object object) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
CriterionToPredicateConverterImpl.property
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
+ Coverage 71.98% 72.12% +0.14%
==========================================
Files 810 809 -1
Lines 16615 16602 -13
Branches 967 958 -9
==========================================
+ Hits 11960 11974 +14
+ Misses 4252 4234 -18
+ Partials 403 394 -9
☔ View full report in Codecov by Sentry. |
0b9f975
to
d589eed
Compare
What this PR changes/adds
Uniform behavior between
InMemory
andSql
store implementationsWhy it does that
consistency
Further notes
like
support on InMemory implementationsboolean
criterion in sql implementationTestBase
classes@Nested
annotation in theTestBase
classes because they were becoming too hard to maintain.ReflectionUtil
ContractNegotiation
andTransferProcess
#3321Linked Issue(s)
Closes #3328
Closes #3059
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.