feat: dsp transfer process validation #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
force-pushed
the
2936-dsp-transfer-process-validation
branch
from
89b5644
to
c81441b
Compare
wolf4ood
approved these changes
Aug 28, 2023
ndkrimbacher
pushed a commit
to nexyo-io/DataSpaceConnector
that referenced
this pull request
Oct 4, 2023
* extract component to handle dsp requests logic * Implement validators * update dependencies * Avoid duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Validate DSP transfer endpoints with
JsonObjectValidatorWhy it does that
consistency
Further notes
DspRequestHandlercomponent, that takes care of all the DSP controllers logic, it's enough to build aDspRequestobject (Get or Post) and pass to the correct method (getResource,createResource,updateResource). This removed a lot of duplicated code and logic.ProcessRemoteMessage(why is thesetProtocolon that interface and not on its superinterface?) that will likely be improved within the upcoming "dsp completion" issues.Linked Issue(s)
Closes #2936
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.