fix: send correlation id as process id in the transfer messages

[ndr-brt]

What this PR changes/adds

Send correlationId and not transfer process id in the protocol messages

Why it does that

fix bug

Further notes

• I enhanced the e2e transfer tests by making the TP going to COMPLETED, this was done adding the control-plane-api and control-plane-api-client to the runtimes
• question 1: given that we have this control-plane to data-plane communication I wonder if we need the statusChecker at all. From an hi level perspective it is correct that the data plane has the knowledge about the transfer completion, this will download some responsibilities from the control-plane
• question 2 Currently as specified in consumer TransferProcesses not Transitioning to Completed State #3334 not everyone is aware that there's this communication layer between CP and DP so I was wondering if it would be better to get rid of the NoopTransferProcessClient to clearly state that a DP needs to communicate with the CP, otherwise it should not start.

thoughts on these 2?

Linked Issue(s)

Closes #3377
Closes #3334

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

[wolf4ood]

@ndr-brt

IMHO

1. I would be inclined to remove the status checker since it require client side polling, which can slowdown the client statemachine. Since the provider dataplane knows when the transfer is finished it make sense to propagate it directly via TransferCompletionMessage

2. Probably it make sense to enforce this communication in the runtime without providing a noop one.

[codecov-commenter]

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (149710a) 72.07% compared to head (dc118f6) 72.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3387   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         828      828           
  Lines       16795    16796    +1     
  Branches      954      954           
=======================================
+ Hits        12105    12106    +1     
  Misses       4280     4280           
  Partials      410      410           

Files Changed	Coverage Δ
...r/transfer/process/TransferProcessManagerImpl.java	92.06% <66.66%> (-0.55%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.