fix: require key-id when resolving key material #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
fix/require_kid_in_did_verificationmethod
branch
from
e4bc088
to
d63e076
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3655 +/- ##
==========================================
- Coverage 71.76% 71.74% -0.02%
==========================================
Files 916 916
Lines 18356 18353 -3
Branches 1041 1041
==========================================
- Hits 13173 13168 -5
- Misses 4727 4729 +2
Partials 456 456 ☔ View full report in Codecov by Sentry. |
jimmarino
approved these changes
Nov 24, 2023
paullatzelsperger
force-pushed
the
fix/require_kid_in_did_verificationmethod
branch
from
d63e076
to
604e1b8
Compare
paullatzelsperger
deleted the
fix/require_kid_in_did_verificationmethod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR changes the public key resolution, in that the
kidis only required, if the DID contains multiple verification methods.Why it does that
Taking the first verification method if no
kidis given is dangerous and wrong.Further notes
JwtPresentationVerifiernow uses theDidPublicKeyResolverinstead of theDidResolverRegistry, which is better, because it limits the API surfaceLinked Issue(s)
Closes #3649
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.