refactor: moved security checks in protocol service layer #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
refactor/3667_protocol_services
branch
2 times, most recently
from
987a239
to
a55deff
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3668 +/- ##
============================================
- Coverage 71.68% 4.46% -67.22%
- Complexity 0 236 +236
============================================
Files 916 917 +1
Lines 18415 18413 -2
Branches 1043 1041 -2
============================================
- Hits 13200 823 -12377
- Misses 4757 17573 +12816
+ Partials 458 17 -441 ☔ View full report in Codecov by Sentry. |
wolf4ood
force-pushed
the
refactor/3667_protocol_services
branch
from
a55deff
to
b655f91
Compare
wolf4ood
requested review from
paullatzelsperger,
ronjaquensel,
juliapampus and
ndr-brt
as code owners
ndr-brt
reviewed
Nov 29, 2023
...e-services/src/main/java/org/eclipse/edc/connector/service/protocol/BaseProtocolService.java
Outdated
Show resolved
Hide resolved
wolf4ood
force-pushed
the
refactor/3667_protocol_services
branch
from
87a1ffd
to
3d36175
Compare
jimmarino
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements the refactor outlined in DR #3665
Why it does that
Decoupling the net protocol from the security checksm which are now delegated to the protocol service layer.
This also will allow use to attach contextual information to the verification process.
Further notes
In this PR since we are pushing here the invocation of the
IdentityServicewe don't know the audience here/ The audience removal will be tackle in subsequent PRs.IdentityServicethat relies on this parameter would not work for the time being.Linked Issue(s)
Closes #3667
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.