-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add capability to register an embedded dataplane #3902
feat: Add capability to register an embedded dataplane #3902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
05f5b59
to
2bcdb1b
Compare
2bcdb1b
to
4da6f51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I have some serious concerns as this code appears to be a near copy of this code without attribution:
We can't have that. Also:
- The code style does not adhere to EDC guidelines
- There is no documentation
- The implementation can be simplified and clarified in places
My suggestion is to close this PR due to the issue of improper attribution, open a discussion, and let's work through how to approach the implementation from a clean slate.
Ok, sure. Let's do it 😊 |
Hi @jimmarino Thanks for your review 😊 |
Please review the coding guidelines (including running checkstyle). For point 3, open a discussion with a technical proposal for how you want the registration process to work. I want to start from a clean slate, not the current code. |
Okay, thanks again, I'll do as you suggest |
What this PR changes/adds
This PR contributes with an extension to enable an embedded data plane to be register using a configuration file without the need to do explicitly through an API
Why it does that
When doing unit tests and there is a necessity to register an embedded data plane, before it was necessary to do so through an API request, now it is possible to use configuration.
Linked Issue(s)
Closes #2226