Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sequence diagrams to DPS doc #3905

Merged

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR adds two sequence diagrams to the documentation for DataPlane Signaling

Why it does that

documentation

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3903

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 14 milestone Feb 22, 2024
@paullatzelsperger paullatzelsperger added the documentation Improvements or additions to documentation label Feb 22, 2024
@jimmarino
Copy link
Contributor

Can we separate out the implementation details of the DataPlaneAccessTokenService? I don't want people to get confused with extension points vs the specific implementation?

@paullatzelsperger paullatzelsperger merged commit c3db076 into eclipse-edc:main Feb 22, 2024
5 checks passed
@paullatzelsperger paullatzelsperger deleted the doc/dps_add_sequencechart branch February 22, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: Amend Architecture Document with sequence diagram
3 participants