feat: adds OpenApi spec for the new signaling APIs #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/3897_dps_protocol
branch
2 times, most recently
from
61eec78
to
dbd37bc
Compare
wolf4ood
added
dpf
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...c/main/java/org/eclipse/edc/connector/dataplane/api/controller/v1/DataPlaneSignalingApi.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/3897_dps_protocol
branch
3 times, most recently
from
0bd2216
to
f8351cb
Compare
...ore-spi/src/main/java/org/eclipse/edc/spi/types/domain/transfer/DataFlowResponseMessage.java
Fixed
Show fixed
Hide fixed
...core-spi/src/main/java/org/eclipse/edc/spi/types/domain/transfer/DataFlowSuspendMessage.java
Fixed
Show fixed
Hide fixed
...re-spi/src/main/java/org/eclipse/edc/spi/types/domain/transfer/DataFlowTerminateMessage.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/3897_dps_protocol
branch
from
f8351cb
to
bb7cf00
Compare
jimmarino
approved these changes
Feb 22, 2024
paullatzelsperger
approved these changes
Feb 22, 2024
| @@ -27,12 +27,28 @@ | |||
| import java.util.Objects; | |||
| import java.util.UUID; | |||
|
|
|||
| import static org.eclipse.edc.spi.CoreConstants.EDC_NAMESPACE; | |||
|
|
|||
| /** | |||
| * A request to transfer data from a source to destination. | |||
| */ | |||
| @JsonTypeName("dataspaceconnector:dataflowrequest") | |||
| @JsonDeserialize(builder = DataFlowRequest.Builder.class) | |||
There was a problem hiding this comment.
do we actually need this here?
There was a problem hiding this comment.
The Json stuff you mean?
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a new module
data-plane-signaling-apicontaining the scaffold for a new controller and an OpenAPI spec for the signaling API.The new APIs will be JSON-LD aware, and some the JSON-LD constants are introduced of the
DataFlow* classesThe refactor of
DataFlowRequestwill be handled in subsequent PRs.The reference of
DataAddressin the docs still reference the EDC one and not thedspaceone. To be change once this lands #3841Why it does that
dataplane signaling story
Linked Issue(s)
Closes #3897