Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): replace consumerId and providerId with odrl assignee and assigner #3926

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Feb 27, 2024

What this PR changes/adds

Map assigner and assignee fields in the Policy object in the transformers.
Ensures that every Offer has the assigner property set.

Why it does that

DSP compliance

Further notes

  • in the model objects like ContractAgreement I kept the current nomenclature (consumerId and providerId), to avoid disruptive changes

Linked Issue(s)

Closes #3792
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Feb 27, 2024
@ndr-brt ndr-brt force-pushed the 3792-policy-assignee-and-assigner branch from 251ee57 to 6b98fd6 Compare February 27, 2024 13:56
@ndr-brt ndr-brt force-pushed the 3792-policy-assignee-and-assigner branch from 6b98fd6 to 486b433 Compare February 28, 2024 07:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.09%. Comparing base (7f20ba5) to head (486b433).
Report is 100 commits behind head on main.

Files Patch % Lines
...onObjectToContractAgreementMessageTransformer.java 77.77% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3926      +/-   ##
==========================================
+ Coverage   71.74%   73.09%   +1.34%     
==========================================
  Files         919      934      +15     
  Lines       18457    18831     +374     
  Branches     1037     1072      +35     
==========================================
+ Hits        13242    13764     +522     
+ Misses       4756     4608     -148     
  Partials      459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 2ee7fb8 into eclipse-edc:main Feb 28, 2024
19 checks passed
@ndr-brt ndr-brt deleted the 3792-policy-assignee-and-assigner branch February 28, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of assignee/assigner in policy
4 participants