feat: introduce allowedTransferTypes in DataPlaneInstance #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
enhancement
paullatzelsperger
approved these changes
Mar 4, 2024
| @@ -71,6 +72,10 @@ private void transformProperties(String key, JsonValue jsonValue, DataPlaneInsta | |||
| var set = jsonValue.asJsonArray().stream().map(jv -> transformString(jv, context)).collect(Collectors.toSet()); | |||
| builder.allowedSourceTypes(set); | |||
| } | |||
| case ALLOWED_TRANSFER_TYPES -> { | |||
| var set = jsonValue.asJsonArray().stream().map(jv -> transformString(jv, context)).collect(Collectors.toSet()); | |||
There was a problem hiding this comment.
wouldn't it be more robust to use transformArray or transformArrayOrObject instead? IIRC they should be able to handle string arrays
There was a problem hiding this comment.
Not sure we handle correctly a transforArray or transformArrayOrObject with String.class
There was a problem hiding this comment.
I like this way, because it's more explicit
ndr-brt
approved these changes
Mar 4, 2024
| @@ -71,6 +72,10 @@ private void transformProperties(String key, JsonValue jsonValue, DataPlaneInsta | |||
| var set = jsonValue.asJsonArray().stream().map(jv -> transformString(jv, context)).collect(Collectors.toSet()); | |||
| builder.allowedSourceTypes(set); | |||
| } | |||
| case ALLOWED_TRANSFER_TYPES -> { | |||
| var set = jsonValue.asJsonArray().stream().map(jv -> transformString(jv, context)).collect(Collectors.toSet()); | |||
There was a problem hiding this comment.
I like this way, because it's more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduces
allowedTransferTypesin DataPlaneInstance.A new
selectmethod has been added toDataPlaneSelectorServiceto support selection based also on thetransferType. If it's not present the behaviour will be as today only inspecting source/destination.The current
DataFlowControllers don't use thetransferTypefor selection. For the data plane signaling a newDataFlowControllerwill be introduced #3901 that will take into account thetransferTypefor dispatching the request to the right data plane.Why it does that
enabling data plane signaling protocol for selecting the correct data plane instance
Linked Issue(s)
Closes #3943